twalthr commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r782015915
##########
File path:
flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/HBase2DynamicTableFactory.java
##########
@@ -67,16 +66,23 @@
@Override
public DynamicTableSource createDynamicTableSource(Context context) {
TableFactoryHelper helper = createTableFactoryHelper(this, context);
+ helper.forwardOptions(
+ TABLE_NAME,
+ ZOOKEEPER_ZNODE_PARENT,
+ ZOOKEEPER_QUORUM,
+ NULL_STRING_LITERAL,
+ LOOKUP_ASYNC,
Review comment:
don't allow
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableFactory.java
##########
@@ -79,9 +86,27 @@ public DynamicTableSource createDynamicTableSource(Context
context) {
@Override
public DynamicTableSink createDynamicTableSink(Context context) {
FactoryUtil.TableFactoryHelper helper =
FactoryUtil.createTableFactoryHelper(this, context);
+ helper.forwardOptions(
+ FileSystemConnectorOptions.PATH,
+ FileSystemConnectorOptions.PARTITION_DEFAULT_NAME,
+ FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_KIND,
+ FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_CLASS,
+
FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_TIMESTAMP_PATTERN,
+ FileSystemConnectorOptions.SINK_ROLLING_POLICY_FILE_SIZE,
+
FileSystemConnectorOptions.SINK_ROLLING_POLICY_ROLLOVER_INTERVAL,
+ FileSystemConnectorOptions.SINK_ROLLING_POLICY_CHECK_INTERVAL,
+ FileSystemConnectorOptions.SINK_SHUFFLE_BY_PARTITION,
Review comment:
this sounds dangerous. let's exclude everything except for PATH in the
first version? Otherwise we should ask someone from the SDK team.
##########
File path:
flink-connectors/flink-connector-hbase-1.4/src/main/java/org/apache/flink/connector/hbase1/HBase1DynamicTableFactory.java
##########
@@ -65,16 +65,23 @@
@Override
public DynamicTableSource createDynamicTableSource(Context context) {
TableFactoryHelper helper = createTableFactoryHelper(this, context);
+ helper.forwardOptions(
+ TABLE_NAME,
+ ZOOKEEPER_ZNODE_PARENT,
+ ZOOKEEPER_QUORUM,
+ NULL_STRING_LITERAL,
+ LOOKUP_ASYNC,
Review comment:
not an Hbase1 option? at least is is neither among optional and required
options
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java
##########
@@ -118,19 +118,19 @@
FileSystemTableSink(
DynamicTableFactory.Context context,
+ ReadableConfig config,
Review comment:
same comment as above. let's not pass the context but only what is
needed by the sink.
##########
File path:
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/AbstractFileSystemTable.java
##########
@@ -43,11 +43,10 @@
List<String> partitionKeys;
- AbstractFileSystemTable(DynamicTableFactory.Context context) {
+ AbstractFileSystemTable(DynamicTableFactory.Context context,
ReadableConfig config) {
Review comment:
do we still need the `Context` as an argument? can we simply pass the
objects that we need? I don't think it is bad to list what is actually used in
the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
