XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r782253748
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultEntry.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.highavailability; + +import org.apache.flink.runtime.jobmaster.JobResult; +import org.apache.flink.util.Preconditions; + +/** + * An entry in a {@link JobResultStore} that couples a completed {@link JobResult} to a state that + * represents whether the resources of that JobResult have been finalized ({@link + * JobResultState#CLEAN}) or have yet to be finalized ({@link JobResultState#DIRTY}). + */ +public class JobResultEntry { + + private final JobResult jobResult; + private JobResultState state; Review comment: We changed the way where the `JobResultState` is referenced and how it's handled. We decided to move it out of the `JobResultEntry`. Instead, the `JobResultStore` implementation needs to take care of the `JobResultState`. That way we have a clear separation of responsibilities. The `JobResultEntry` is created outside of the `JobResultStore` and the `JobResultStore`'s responsibility is to manage the state of the `JobResultEntry` in some way. This makes `JobResultEntry` immutable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
