XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r782255723
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.highavailability.nonha.embedded; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.common.JobID; +import org.apache.flink.runtime.highavailability.JobResultEntry; +import org.apache.flink.runtime.highavailability.JobResultStore; +import org.apache.flink.runtime.jobmaster.JobResult; + +import java.util.Collection; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.concurrent.ConcurrentHashMap; +import java.util.stream.Collectors; + +/** + * An implementation of the {@link JobResultStore} which only persists the data to an in-memory map. + */ +public class EmbeddedJobResultStore implements JobResultStore { + + private final Map<JobID, JobResultEntry> inMemoryMap = new ConcurrentHashMap<>(); + + @Override + public void createDirtyResult(JobResult jobResult) { + final JobResultEntry jobResultEntry = JobResultEntry.createDirtyJobResultEntry(jobResult); + inMemoryMap.put(jobResult.getJobId(), jobResultEntry); + } + + @Override + public void markResultAsClean(JobID jobId) throws NoSuchElementException { Review comment: Correct. Another thing I missed in my initial efforts combining the two PRs into a single one. 😇 This is fixed now. The `EmbeddedJobResultStore` holds two collections now: One for the dirty results and one for the clean ones. This has the advantage that we hold a dedicated index on the dirty entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
