Thesharing commented on pull request #17777:
URL: https://github.com/apache/flink/pull/17777#issuecomment-1010705038


   > hi @Thesharing , orignial commits are 4, i just reset the first commit and 
rebase code, then ci is running and you can see the log
   
   Thank you for the rebasing the code. I've checked the failed test cases. If 
we make sure the order of minute units stay the same , the broken tests will 
pass.
   
   Would you mind change the line
   ```
   MINUTES(ChronoUnit.MINUTES, singular("m"), singular("min"), plural("minute"))
   ```
   into
   ```
   MINUTES(ChronoUnit.MINUTES, singular("min"), singular("m"), plural("minute"))
   ```
   and run the CI again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to