Thesharing commented on pull request #17777: URL: https://github.com/apache/flink/pull/17777#issuecomment-1010846811
> Why is the order of units important? Because [tests](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=29288&view=logs&j=0c940707-2659-5648-cbe6-a1ad63045f0a&t=075c2716-8010-5565-fe08-3c4bb45824a4&l=25123) like `StreamOperatorNameTest` will generate optimized plans based on the first one of the units, i.e. "min". If we change the code into `MINUTES(ChronoUnit.MINUTES, singular("m"), singular("min"), plural("minute"))`, the first one is "m" instead of "min". Then the plans will be generated with "m", which makes these tests failed. That's why @liuyongvs touches those unrelated files like `WindowTableFunctionTest.xml` and `WindowAggregateTest.xml`. He changes "min" into "m" in these files. If we change the order into `MINUTES(ChronoUnit.MINUTES, singular("min"), singular("m"), plural("minute"))`, these tests shall be passed.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
