[
https://issues.apache.org/jira/browse/FLINK-25690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17477812#comment-17477812
]
Chesnay Schepler commented on FLINK-25690:
------------------------------------------
??I did not know that it was on its way out.??
This is due to the jUnit 5 migration.
??I think we should add deprecation notice to RetryRule and other classes on
their way out so that people like me could know that they are using deprecated
classes.??
We decided against that because it would imply a ton of deprecation warnings
for hardly any gain.
??I checked RetryExtension, it does not supports this use case [...]??
Are you sure? It works quite a bit differently than the RetryRule.
I did a small test where I added Before-/AfterEach methods to the
{{RetryOnFailureExtensionTest}}, and it does seem to work just fine.
I would currently be in favor of migrating the test to junit5, because that bit
is inevitable, while changes to the RetryRule will not benefit us in the long
run.
There is of course the issue of this being about a flaky test, so it depends a
bit on how much effort it would be.
> RetryRule should allow a callback to be called on exception and failure cases
> -----------------------------------------------------------------------------
>
> Key: FLINK-25690
> URL: https://issues.apache.org/jira/browse/FLINK-25690
> Project: Flink
> Issue Type: Improvement
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: test
>
> RetryRule is a Flink junit rule that allows to retry tests when they
> temporary fail (either by throwing an exception or by failing an assertion)
> usually in case of load. In some cases, there is some treatment to be done
> for the test to be idempotent when retried for example cleaning of created
> data etc...
> Of course, this callback will be optional.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
