[
https://issues.apache.org/jira/browse/FLINK-25690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478050#comment-17478050
]
Etienne Chauchot commented on FLINK-25690:
------------------------------------------
Thanks [~chesnay] for your answer.
?? We decided against that because it would imply a ton of deprecation warnings
for hardly any gain. ??
This makes total sense !
?? Are you sure? It works quite a bit differently than the RetryRule [...] ??
I did not have enough time to test it properly, I just read its code and I saw
that it did not implement _AfterEachCallback_ that is why I though that only
_AfterAll_ was supported. But if it works as I need that is perfect! I will
test in my use case and keep you posted.
?? changes to the RetryRule will not benefit us in the long run ??
I totally agree. I don't plan on changing RetryRule. My plan after your comment
was to use RetryExtension instead. I'll test it in my use case and if I miss
something I'll add it to RetryExtension, if I miss nothing, then that is all
for the best :)
Thanks anyway for the info about Junit 5 migration
> RetryRule should allow a callback to be called on exception and failure cases
> -----------------------------------------------------------------------------
>
> Key: FLINK-25690
> URL: https://issues.apache.org/jira/browse/FLINK-25690
> Project: Flink
> Issue Type: Improvement
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: test
>
> RetryRule is a Flink junit rule that allows to retry tests when they
> temporary fail (either by throwing an exception or by failing an assertion)
> usually in case of load. In some cases, there is some treatment to be done
> for the test to be idempotent when retried for example cleaning of created
> data etc...
> Of course, this callback will be optional.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
