Airblader commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r786763971
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion)
{
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
`orHigherExcludingLatest`?
I feel like "Snapshot" is not really correct here; I would expect e.g.
`release-1.15` to contain 1.15 as the highest one as well (and not 1.16). But
the question is whether 1.15 should be excluded on `release-1.15` or not (no
idea, I don't know the intention).
Flagging the releases (`boolean released`). would be another option.
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion)
{
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
`orHigherExcludingLatest`?
I feel like "Snapshot" is not really correct here; I would expect e.g.
`release-1.15` to contain 1.15 as the highest one as well (and not 1.16). But
the question is whether 1.15 should be excluded on `release-1.15` or not (no
idea, I don't know the intention).
Flagging the releases (`boolean released`) would be another option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
