matriv commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r789664814
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion)
{
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
@zentol After a discussion with @twalthr we came up with another idea.
Keep only one enum the `FlinkVersion` without flags, and change the method
to a `rangeOf` so that the tests can still define what they need. Additionally,
if you agree with that, we will just change the steps `14` & `15` in the
`Checklist to declare the process completed` section so that the release
manager needs only to adjust the `CURRENT_VERSION` on
`TypeSerializerUpgradeTestBase`.
Pushed the commit, so please check and let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
