slinkydeveloper commented on a change in pull request #18349:
URL: https://github.com/apache/flink/pull/18349#discussion_r787503439
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateTableASOperation.java
##########
@@ -26,25 +26,32 @@
import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.function.Supplier;
/** Operation to describe a CREATE TABLE AS statement. */
@Internal
public class CreateTableASOperation implements CreateOperation {
private final CreateTableOperation createTableOperation;
- private final SinkModifyOperation insertOperation;
+ private final Supplier<SinkModifyOperation> insertOperationFactory;
+
+ private SinkModifyOperation insertOperation;
Review comment:
I've modified a bit the structure of `CreateTableASOperation` to make
the summary string senseful (and similar to `SinkModifyOperation`) and remove
that internal mutability. check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
