XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r787467634
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -943,15 +945,26 @@ protected CleanupJobState
jobReachedTerminalState(ExecutionGraphInfo executionGr
archiveExecutionGraph(executionGraphInfo);
if (terminalJobStatus.isGloballyTerminalState()) {
+ final JobID jobId = executionGraphInfo.getJobId();
try {
- jobResultStore.createDirtyResult(
-
JobResult.createFrom(executionGraphInfo.getArchivedExecutionGraph()));
+ if (jobResultStore.hasCleanJobResultEntry(jobId)) {
+ log.warn(
Review comment:
I added it because it indicates that something strange is going on in
the `JobResultStore` considering that the user could modify files in the
directory of the file-based implementation. In general, this warning should
never pop up. But if somebody did something wrong with file names, Flink might
store the wrong state under that job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
