JingGe commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r787635789



##########
File path: 
flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/HBase2DynamicTableFactory.java
##########
@@ -136,4 +133,20 @@ public String factoryIdentifier() {
         set.add(LOOKUP_MAX_RETRIES);
         return set;
     }
+
+    @Override
+    public Set<ConfigOption<?>> forwardOptions() {

Review comment:
       Thanks for the info. In this case, this PR will break thing and it looks 
like fixing it will take long time. I would suggest letting @chesnay be aware 
of this. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to