JingGe commented on a change in pull request #18290:
URL: https://github.com/apache/flink/pull/18290#discussion_r788657052



##########
File path: 
flink-connectors/flink-connector-hbase-2.2/src/main/java/org/apache/flink/connector/hbase2/HBase2DynamicTableFactory.java
##########
@@ -136,4 +133,20 @@ public String factoryIdentifier() {
         set.add(LOOKUP_MAX_RETRIES);
         return set;
     }
+
+    @Override
+    public Set<ConfigOption<?>> forwardOptions() {

Review comment:
       Now I got your point. We had content-out-of-synch issue previously and 
there is a [ticket](https://issues.apache.org/jira/browse/FLINK-25506) for 
doing it, at least for HBase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to