LadyForest edited a comment on pull request #18394: URL: https://github.com/apache/flink/pull/18394#issuecomment-1016159041
> I just feel, the testing classes are too complicated, can we simplify them? We only need to test what we need, there is no need to have very strong features. I've made some efforts to simplify the implementation. However, it's a little hard for us to avoid the overall overheads for implementing source/sink(split, reader, enumerator, writer, committer, committable, etc.) since we're sitting in the `table-common` module. I've split the static inner classes into top-level classes to achieve better readability to make each file smaller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
