JingsongLi commented on a change in pull request #18394:
URL: https://github.com/apache/flink/pull/18394#discussion_r788357601
##########
File path:
flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestManagedTableFactory.java
##########
@@ -175,37 +191,153 @@ private ChangelogMode parseChangelogMode(String string) {
return builder.build();
}
- /** Managed {@link DynamicTableSink} for testing. */
- public static class TestManagedTableSink implements DynamicTableSink {
-
- @Override
- public ChangelogMode getChangelogMode(ChangelogMode requestedMode) {
- return requestedMode;
+ private static LinkedHashMap<String, String> sortPartitionKey(
+ List<String> partitionKeys, Map<String, String>
unresolvedPartitionSpec) {
+ LinkedHashMap<String, String> partialResolvedPartitionSpec = new
LinkedHashMap<>();
+ for (String partitionKey : partitionKeys) {
+ partialResolvedPartitionSpec.put(
+ partitionKey, unresolvedPartitionSpec.get(partitionKey));
}
+ return partialResolvedPartitionSpec;
+ }
- @Override
- public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
- throw new UnsupportedOperationException();
+ private static Pattern buildPartitionRegex(
Review comment:
Just use `PartitionPathUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
