CrynetLogistics commented on a change in pull request #18314:
URL: https://github.com/apache/flink/pull/18314#discussion_r789006610
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/config/AWSUnifiedSinksConfigConstants.java
##########
@@ -15,19 +15,26 @@
* limitations under the License.
*/
-package org.apache.flink.connector.kinesis.config;
+package org.apache.flink.connector.aws.config;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.connector.kinesis.util.AWSKinesisDataStreamsUtil;
+import org.apache.flink.connector.aws.util.AWSUnifiedSinksUtil;
-/** Defaults for {@link AWSKinesisDataStreamsUtil}. */
+/** Defaults for {@link AWSUnifiedSinksUtil}. */
@PublicEvolving
-public class AWSKinesisDataStreamsConfigConstants {
+public class AWSUnifiedSinksConfigConstants {
public static final String BASE_KINESIS_USER_AGENT_PREFIX_FORMAT =
"Apache Flink %s (%s) Kinesis Connector";
- /** Identifier for user agent prefix. */
+ /** Kinesis identifier for user agent prefix. */
public static final String KINESIS_CLIENT_USER_AGENT_PREFIX =
"aws.kinesis.client.user-agent-prefix";
+
+ public static final String BASE_FIREHOSE_USER_AGENT_PREFIX_FORMAT =
+ "Apache Flink %s (%s) Firehose Connector";
+
+ /** Firehose identifier for user agent prefix. */
+ public static final String FIREHOSE_CLIENT_USER_AGENT_PREFIX =
+ "aws.firehose.client.user-agent-prefix";
Review comment:
Sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
