CrynetLogistics commented on a change in pull request #18314: URL: https://github.com/apache/flink/pull/18314#discussion_r789109263
########## File path: flink-connectors/flink-connector-aws-kinesis-data-firehose/src/test/java/org/apache/flink/connector/firehose/sink/testutils/LocalstackContainer.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.firehose.sink.testutils; + +import org.rnorth.ducttape.ratelimits.RateLimiter; +import org.rnorth.ducttape.ratelimits.RateLimiterBuilder; +import org.rnorth.ducttape.unreliables.Unreliables; +import org.testcontainers.containers.GenericContainer; +import org.testcontainers.containers.wait.strategy.AbstractWaitStrategy; +import org.testcontainers.utility.DockerImageName; +import software.amazon.awssdk.services.s3.S3AsyncClient; +import software.amazon.awssdk.services.s3.model.S3Object; + +import java.net.URISyntaxException; +import java.util.List; +import java.util.concurrent.Callable; +import java.util.concurrent.ExecutionException; + +import static java.util.concurrent.TimeUnit.SECONDS; + +/** + * A class wrapping the Localstack container that provides mock implementations of many common AWS + * services. + */ +public class LocalstackContainer extends GenericContainer<LocalstackContainer> { + + private static final int CONTAINER_PORT = 4566; + + public LocalstackContainer(DockerImageName imageName) { + super(imageName); + withExposedPorts(CONTAINER_PORT); + waitingFor(new ListStreamsWaitStrategy()); + } + + public String getEndpoint() { + return String.format("https://%s:%s";, getHost(), getMappedPort(CONTAINER_PORT)); + } + + private class ListStreamsWaitStrategy extends AbstractWaitStrategy { + private static final int TRANSACTIONS_PER_SECOND = 1; + + private final RateLimiter rateLimiter = + RateLimiterBuilder.newBuilder() + .withRate(TRANSACTIONS_PER_SECOND, SECONDS) + .withConstantThroughput() + .build(); + + @Override + protected void waitUntilReady() { + try { + Thread.sleep(10000); Review comment: If I'm honest, I haven't tried without this timeout. I guess I fear that we'll not notice it in ~5-10 runs and push out something intermittently failing. I've removed it for now and I guess we'll notice if it is failing for now. I have followed the Flink Azure Pipelines setup guide and my request is awaiting Microsoft to grant the free instances to my account. Once that is done, I will launch 1000 runs of this integration test ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
