JingGe commented on a change in pull request #18397:
URL: https://github.com/apache/flink/pull/18397#discussion_r789714596
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaValueOnlyDeserializerWrapper.java
##########
@@ -62,8 +75,15 @@ public void open(DeserializationSchema.InitializationContext
context) throws Exc
deserializerClass.getName(),
Deserializer.class,
getClass().getClassLoader());
+
+ if (config.isEmpty()) {
+ return;
+ }
+
if (deserializer instanceof Configurable) {
((Configurable) deserializer).configure(config);
+ } else {
Review comment:
The first one was there before this PR, it should already be tested. For
the third one, either we do nothing like I proposed which might need a test, or
we don't change it, which will be one of the first or the second case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
