JingGe commented on a change in pull request #18397:
URL: https://github.com/apache/flink/pull/18397#discussion_r788957396
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaRecordDeserializationSchema.java
##########
@@ -123,9 +121,8 @@ default void
open(DeserializationSchema.InitializationContext context) throws Ex
* @return A {@link KafkaRecordDeserializationSchema} that deserialize the
value with the given
* deserializer.
*/
- static <V, D extends Configurable & Deserializer<V>>
- KafkaRecordDeserializationSchema<V> valueOnly(
- Class<D> valueDeserializerClass, Map<String, String>
config) {
+ static <V, D extends Deserializer<V>> KafkaRecordDeserializationSchema<V>
valueOnly(
Review comment:
Thanks for the review.
Backward compatibility has been considered. This PR just reduced the type
control of the input parameter DeserializationSchema a little bit from
`Configurable & Deserializer<V>` to `Deserializer<V>`. The
[Wrapper](https://github.com/apache/flink/pull/18397/files#diff-ed43df5179d747c55bc2b9478ead0b15d49a5275e76827121d31904db779449fL68)
will check internally and call
`org.apache.kafka.common.Configurable.configure` if the schema implements
`Configurable`. In this way, older case will be supported implicitly without
confusing users who use `Deserializer.configure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
