XComp commented on a change in pull request #18189:
URL: https://github.com/apache/flink/pull/18189#discussion_r789730009
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherGatewayServiceFactory.java
##########
@@ -118,7 +120,12 @@ public ApplicationDispatcherGatewayServiceFactory(
return DefaultDispatcherGatewayService.from(dispatcher);
}
- private List<JobID> getRecoveredJobIds(final Collection<JobGraph>
recoveredJobs) {
- return
recoveredJobs.stream().map(JobGraph::getJobID).collect(Collectors.toList());
+ private Set<JobID> getRecoveredJobIds(
+ final Collection<JobGraph> recoveredJobs,
+ final Collection<JobResult> recoveredDirtyJobs) {
+ return Stream.concat(
+ recoveredJobs.stream().map(JobGraph::getJobID),
+ recoveredDirtyJobs.stream().map(JobResult::getJobId))
+ .collect(Collectors.toSet());
Review comment:
We discussed the approach offline. I added test in
`ApplicationDispatcherBootstrapITCase` to cover the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
