nirtsruya commented on a change in pull request #18449:
URL: https://github.com/apache/flink/pull/18449#discussion_r790560815
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java
##########
@@ -37,6 +38,7 @@
ConcreteBuilderT extends AsyncSinkBaseBuilder<?, ?, ?>> {
private ElementConverter<InputT, RequestEntryT> elementConverter;
+ private FatalExceptionHandler<RequestEntryT> fatalExceptionHandler;
Review comment:
Thanks, as I commented below, if we think the requestEntries should not
be passed to the handler (as we don't believe letting the user access to the
failed request entries - in order to log, publish to DLQ etc makes sense) ,
then I agree, no need to propagate these in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
