dannycranmer commented on a change in pull request #18449:
URL: https://github.com/apache/flink/pull/18449#discussion_r790563706
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java
##########
@@ -37,6 +38,7 @@
ConcreteBuilderT extends AsyncSinkBaseBuilder<?, ?, ?>> {
private ElementConverter<InputT, RequestEntryT> elementConverter;
+ private FatalExceptionHandler<RequestEntryT> fatalExceptionHandler;
Review comment:
It would be a bigger change, but maybe instead of passing the
`RequestEntryT` we could pass the raw objects. Since `RequestEntryT` is
destination specific it might not be ideal for forwarding on, and we do not
want to require the exception handler to deserialise. Would appreciate input
from @CrynetLogistics here .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
