JingGe commented on a change in pull request #18428: URL: https://github.com/apache/flink/pull/18428#discussion_r791771156
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/Committables.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.operators.sink.committables; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.sink2.Committer; +import org.apache.flink.streaming.api.connector.sink2.CommittableSummary; +import org.apache.flink.streaming.api.connector.sink2.CommittableWithLineage; + +import java.io.IOException; +import java.util.Collection; + +/** + * Internal wrapper to handle the committing of committables. Review comment: It seems that there are now two meanings of the word "comittables", since the new interface `Committables` has been created. Afaik, "commitables" has been used as a conceptual name previously very often. There is no corresponding domain entity developed for it and just let it open for users to define via the generic type `CommT`. Since all methods in this interface are working with subclasses of `ComittableMessage`, this interface is actually responsible for managing all commitables and all kinds of `ComittableMessage`, i.e. `ComittableSummary` and `ComittableWithLineage`, which turns out that calling this interface as `ComittablesManager` would be alternative naming option that is easier to understand the concept behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
