JingGe commented on a change in pull request #18428: URL: https://github.com/apache/flink/pull/18428#discussion_r791802037
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittables.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.operators.sink.committables; + +import org.apache.flink.annotation.Internal; + +/** + * This interface adds checkpoint meta information to the committable. + * + * @param <CommT> type of the committable + */ +@Internal +public interface CheckpointCommittables<CommT> extends Committables<CommT> { Review comment: From OOP point of view, this interface introduced the checkpoint, which means `Committables` must be at a higher level above it and has nothing to do with the checkpoint. But the fact is that `Committables` has already been dealing with `CommittableSummary` and `CommittableWithLineage` that can all provide checkpointId. If it was intended to distinguish between them, more info will be required to describe when to use `Committables` (at a higher abstraction level without the checkpoint concept) and when to use `CheckpointCommittables`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
