YuriGusev commented on a change in pull request #18518:
URL: https://github.com/apache/flink/pull/18518#discussion_r792479047
##########
File path:
flink-connectors/flink-connector-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/util/AWSDynamoDbUtil.java
##########
@@ -0,0 +1,184 @@
+/*
Review comment:
As an alternative we could let user to construct the client themselves
and pass it via a provider:
`
interface DynamoDbClientProvider {
DynamoDbAsyncClient getClient();
}
`
Then we do not have to create the wrapper util class and give full
flexibility to the user on what configuration options to set.
The downside will be that we leak DynamoDB SDK interfaces.
In the end I took same approach as we use in other places. But may be we
should consider this option.
What do you think @CrynetLogistics ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
