dawidwys commented on a change in pull request #18482:
URL: https://github.com/apache/flink/pull/18482#discussion_r793698672
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointOptionsTest.java
##########
@@ -55,9 +56,17 @@ public void testSavepoint() throws Exception {
final byte[] locationBytes = new byte[rnd.nextInt(41) + 1];
rnd.nextBytes(locationBytes);
+ final SnapshotType[] snapshotTypes = {
+ CHECKPOINT,
+ FULL_CHECKPOINT,
+ SavepointType.savepoint(SavepointFormatType.CANONICAL),
+ SavepointType.suspend(SavepointFormatType.CANONICAL),
+ SavepointType.terminate(SavepointFormatType.CANONICAL)
+ };
Review comment:
Hmm... good point. So far I could not figure out a solution. However I
am wondering how important it is we cover all different configurations. In the
end we are pretty much testing that java serialization works well here. Is that
crucial that we test all possible values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
