fapaul commented on a change in pull request #18428:
URL: https://github.com/apache/flink/pull/18428#discussion_r794279946
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStreamSink.java
##########
@@ -40,32 +45,46 @@
private final PhysicalTransformation<T> transformation;
- @SuppressWarnings("unchecked")
- protected DataStreamSink(DataStream<T> inputStream, StreamSink<T>
operator) {
- this.transformation =
- (PhysicalTransformation<T>)
- new LegacySinkTransformation<>(
- inputStream.getTransformation(),
- "Unnamed",
- operator,
-
inputStream.getExecutionEnvironment().getParallelism());
- }
-
- @SuppressWarnings("unchecked")
- protected DataStreamSink(DataStream<T> inputStream, Sink<T, ?, ?, ?> sink)
{
- transformation =
- (PhysicalTransformation<T>)
- new SinkTransformation<>(
- inputStream.getTransformation(),
- sink,
- "Unnamed",
-
inputStream.getExecutionEnvironment().getParallelism());
+ protected DataStreamSink(PhysicalTransformation<T> transformation) {
+ this.transformation = checkNotNull(transformation);
+ }
+
+ static <T> DataStreamSink<T> forSinkFunction(
+ DataStream<T> inputStream, SinkFunction<T> sinkFunction) {
+ StreamSink<T> sinkOperator = new StreamSink<>(sinkFunction);
+ PhysicalTransformation<T> transformation =
+ new LegacySinkTransformation<>(
+ inputStream.getTransformation(),
+ "Unnamed",
+ sinkOperator,
+
inputStream.getExecutionEnvironment().getParallelism());
+ inputStream.getExecutionEnvironment().addOperator(transformation);
+ return new DataStreamSink<>(transformation);
+ }
+
+ static <T> DataStreamSink<T> forSink(DataStream<T> inputStream, Sink<T>
sink) {
+ StreamExecutionEnvironment executionEnvironment =
inputStream.getExecutionEnvironment();
+ SinkTransformation<T, T> transformation =
+ new SinkTransformation<>(
+ inputStream,
+ sink,
+ inputStream.getTransformation(),
+ inputStream.getType(),
+ "Sink",
+ executionEnvironment.getParallelism());
inputStream.getExecutionEnvironment().addOperator(transformation);
+ return new DataStreamSink<>(transformation);
+ }
+
+ @Internal
+ public static <T> DataStreamSink<T> forSinkV1(
+ DataStream<T> inputStream,
org.apache.flink.api.connector.sink.Sink<T, ?, ?, ?> sink) {
+ return forSink(inputStream, SinkV1Adapter.wrap(sink));
}
/** Returns the transformation that contains the actual sink operator of
this sink. */
@Internal
- public Transformation<T> getTransformation() {
+ public Transformation<?> getTransformation() {
Review comment:
I reverted that change it feels unncessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
