fapaul commented on a change in pull request #18428:
URL: https://github.com/apache/flink/pull/18428#discussion_r794284695
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStreamSink.java
##########
@@ -40,32 +45,46 @@
private final PhysicalTransformation<T> transformation;
- @SuppressWarnings("unchecked")
- protected DataStreamSink(DataStream<T> inputStream, StreamSink<T>
operator) {
- this.transformation =
- (PhysicalTransformation<T>)
- new LegacySinkTransformation<>(
- inputStream.getTransformation(),
- "Unnamed",
- operator,
-
inputStream.getExecutionEnvironment().getParallelism());
- }
-
- @SuppressWarnings("unchecked")
- protected DataStreamSink(DataStream<T> inputStream, Sink<T, ?, ?, ?> sink)
{
- transformation =
- (PhysicalTransformation<T>)
- new SinkTransformation<>(
- inputStream.getTransformation(),
- sink,
- "Unnamed",
-
inputStream.getExecutionEnvironment().getParallelism());
+ protected DataStreamSink(PhysicalTransformation<T> transformation) {
+ this.transformation = checkNotNull(transformation);
+ }
+
+ static <T> DataStreamSink<T> forSinkFunction(
+ DataStream<T> inputStream, SinkFunction<T> sinkFunction) {
Review comment:
This is more like a cleanup that the `DataStreamSink` is the central
entry point to add the sink transformation to the datastream. I suspect the
`SinkFunction` will be in Flink for a longer time still because it requires
Flink 2.0 to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
