zentol commented on a change in pull request #18567:
URL: https://github.com/apache/flink/pull/18567#discussion_r797639576
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
##########
@@ -128,7 +128,17 @@ private void registerShutDownFuture() {
public CompletableFuture<Void> stopApplication(
final ApplicationStatus applicationStatus, final @Nullable String
diagnostics) {
return internalShutdown(
- () ->
resourceManagerService.deregisterApplication(applicationStatus, diagnostics));
+ () ->
+ resourceManagerService
+ .deregisterApplication(applicationStatus,
diagnostics)
+ // suppress deregister exception because of
FLINK-25893
+ .exceptionally(
+ exception -> {
Review comment:
Can we not make this more specific?
It sounds like we know of 2 specific circumstances where we expect this to
fail, but now we are ignoring all errors, even when everything on our side is
working properly.
I intended to add a dedicated exception for the RPC endpoint case in
https://github.com/zentol/flink/commits/25269.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
