tillrohrmann commented on a change in pull request #18567:
URL: https://github.com/apache/flink/pull/18567#discussion_r798342075
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
##########
@@ -128,7 +128,17 @@ private void registerShutDownFuture() {
public CompletableFuture<Void> stopApplication(
final ApplicationStatus applicationStatus, final @Nullable String
diagnostics) {
return internalShutdown(
- () ->
resourceManagerService.deregisterApplication(applicationStatus, diagnostics));
+ () ->
+ resourceManagerService
+ .deregisterApplication(applicationStatus,
diagnostics)
+ // suppress deregister exception because of
FLINK-25893
+ .exceptionally(
+ exception -> {
Review comment:
Once we have FLINK-25269 merged we can make this band aid more specific.
At the moment it is simply a stopgap solution.
For the general solution of FLINK-25893, we probably need to rethink the
division of responsibilities of registering and deregistering of applications.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
