XComp commented on a change in pull request #18536:
URL: https://github.com/apache/flink/pull/18536#discussion_r798421812
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java
##########
@@ -873,69 +878,96 @@ public boolean deletePermanent(JobID jobId,
PermanentBlobKey key) {
* doesn't touch the job's entry in the {@link BlobStore} to enable
recovering.
*
* @param jobId The {@code JobID} of the job that is subject to cleanup.
- * @throws IOException if the cleanup failed.
*/
@Override
- public void localCleanup(JobID jobId) throws IOException {
+ public CompletableFuture<Void> localCleanupAsync(JobID jobId, Executor
cleanupExecutor) {
checkNotNull(jobId);
+ return CompletableFuture.runAsync(
Review comment:
Good point 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
