XComp commented on a change in pull request #18536:
URL: https://github.com/apache/flink/pull/18536#discussion_r798451147
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -1169,6 +1136,7 @@ private void jobMasterFailed(JobID jobId, Throwable
cause) {
}
CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
+ getMainThreadExecutor().assertRunningInMainThread();
Review comment:
Same as for the `Dispatcher.localCleanup(JobID)`: I thought of having
this explicit safeguard here being more helpful because it's otherwise only
visible through the `DefaultResourceCleaner.cleanupAsync` JavaDoc that it
should be called from the main thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
