XComp opened a new pull request #18626:
URL: https://github.com/apache/flink/pull/18626


   ## What is the purpose of the change
   
   Refactored the tests around cleanup collecting cleanup-relevant tests in 
`DispatcherResourceCleanupTest`
   
   ## Brief change log
   
   * Makes `BlobServerClenupTest` based on JUnit5 and AssertJ and adds 
cleanup-related tests
   * `DispatcherResourceCleanupTest` is refactored to only rely on the cleanup 
without testing the downstream CleanableResources. Testing that the right 
components are cleaned is tested in `DispatcherResourceCleanerFactoryTest`.  
The actual cleanup for each component is then tested in the corresponding 
component tests.
   * Additionally, I added test cases in `DispatcherResourceCleanerFactoryTest` 
for verifying that the `JobResult` is marked as dirty before the cleanup and 
clean after the cleanup
   
   ## Verifying this change
   
   The PR itself is just tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to