XComp commented on a change in pull request #18626:
URL: https://github.com/apache/flink/pull/18626#discussion_r799417802
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -169,35 +170,103 @@ public Dispatcher(
DispatcherBootstrapFactory dispatcherBootstrapFactory,
DispatcherServices dispatcherServices)
throws Exception {
+ this(
+ rpcService,
+ fencingToken,
+ recoveredJobs,
+ recoveredDirtyJobs,
+ dispatcherBootstrapFactory,
+ dispatcherServices,
+ new DefaultJobManagerRunnerRegistry(16));
+ }
+
+ private Dispatcher(
+ RpcService rpcService,
+ DispatcherId fencingToken,
+ Collection<JobGraph> recoveredJobs,
+ Collection<JobResult> globallyTerminatedJobs,
+ DispatcherBootstrapFactory dispatcherBootstrapFactory,
+ DispatcherServices dispatcherServices,
+ JobManagerRunnerRegistry jobManagerRunnerRegistry)
+ throws Exception {
+ this(
+ rpcService,
+ fencingToken,
+ recoveredJobs,
+ globallyTerminatedJobs,
+ dispatcherServices.getConfiguration(),
+ dispatcherServices.getHighAvailabilityServices(),
+ dispatcherServices.getResourceManagerGatewayRetriever(),
+ dispatcherServices.getHeartbeatServices(),
+ dispatcherServices.getBlobServer(),
+ dispatcherServices.getFatalErrorHandler(),
+ dispatcherServices.getJobGraphWriter(),
+ dispatcherServices.getJobResultStore(),
+ dispatcherServices.getJobManagerMetricGroup(),
+ dispatcherServices.getMetricQueryServiceAddress(),
+ dispatcherServices.getIoExecutor(),
+ dispatcherServices.getHistoryServerArchivist(),
+ dispatcherServices.getArchivedExecutionGraphStore(),
+ dispatcherServices.getJobManagerRunnerFactory(),
+ dispatcherBootstrapFactory,
+ dispatcherServices.getOperationCaches(),
+ jobManagerRunnerRegistry,
+ new DispatcherResourceCleanerFactory(jobManagerRunnerRegistry,
dispatcherServices));
+ }
+
+ @VisibleForTesting
+ protected Dispatcher(
Review comment:
The main motivation was to remove this invariant in testing where we
have to create an instance of `DispatcherServices` just to pass it into the
`TestingDispatcher` and to get all the parameters out again. But considering
our discussion in terms of backwards-compatibility - that's probably a perfect
example which we shouldn't do to not make life harder for backports... 🤔
I will refactor it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
