matriv commented on a change in pull request #18632:
URL: https://github.com/apache/flink/pull/18632#discussion_r799538777
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -486,14 +486,12 @@
LocalDateTime.of(2021, 9, 27, 12, 34,
56, 123000000)
.atZone(CET)
.toInstant()))
- // https://issues.apache.org/jira/browse/FLINK-24446
Fractional seconds are
- // lost
.fromCase(
Review comment:
Can you please add a couple more tests, with for example: `123450000`,
and then cast to a TIMESTAMP with other precisions, like:
`CAST(......123456700 AS TIMESTAMP(4))` ?
(I'm adding more castTo in this PR:
https://github.com/apache/flink/pull/18582/files#diff-e0805a10185bbcbb1b44d8b76b5d1bf8b2aff7bc3e6fa42df9e6f26b72b7077bR503
as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
