slinkydeveloper commented on a change in pull request #18632:
URL: https://github.com/apache/flink/pull/18632#discussion_r799610154
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -486,14 +486,12 @@
LocalDateTime.of(2021, 9, 27, 12, 34,
56, 123000000)
.atZone(CET)
.toInstant()))
- // https://issues.apache.org/jira/browse/FLINK-24446
Fractional seconds are
- // lost
.fromCase(
Review comment:
@matriv should we also check that trimming is performed? e.g.:
```
CastTestSpecBuilder.testCastTo(TIMESTAMP(4))
.fromCase(
STRING(),
fromString("2021-09-27 12:34:56.12345"),
TimestampData.fromLocalDateTime(LocalDateTime.of(2021, 9, 27, 12, 34,
56, 123400000))),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
