slinkydeveloper commented on a change in pull request #18624:
URL: https://github.com/apache/flink/pull/18624#discussion_r799559443
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/InternalConfigOptions.java
##########
@@ -50,4 +51,13 @@
+ " as UTC+0 milliseconds since epoch for
simplification, this config will be used by"
+ " some temporal functions like
LOCAL_TIMESTAMP in batch job to make sure these"
+ " temporal functions has query-start
semantics.");
+
+ @Experimental
+ public static final ConfigOption<Boolean>
TABLE_EXEC_NON_TEMPORAL_SORT_ENABLED =
+ key("table.exec.sort.non-temporal.enabled")
Review comment:
Any reason for not using the notation `__` like in the other 2 config
options above?
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecCalc.java
##########
@@ -42,6 +42,7 @@
@ExecNodeMetadata(
name = "stream-exec-calc",
version = 1,
+ consumedOptions = {"table.optimizer.simplify-operator-name-enabled"},
Review comment:
I see this one is used everywhere, does it makes sense to assume it by
default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
