zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r800509878
##########
File path: flink-connectors/flink-connector-elasticsearch6/pom.xml
##########
@@ -114,6 +114,13 @@ under the License.
<type>test-jar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same comment as for es7
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -549,6 +549,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
What does the hive connector need it for? because of some format?
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
I wouldn't mark it as optional.
##########
File path:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -86,6 +86,12 @@ under the License.
</dependency>
-->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
see above
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -157,6 +157,13 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
Review comment:
should be unnecessary since flink-dist will provide it
##########
File path: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
This shouldn't be necessary as flink-dist should provide it.
##########
File path: flink-end-to-end-tests/flink-quickstart-test/pom.xml
##########
@@ -37,6 +37,11 @@ under the License.
<artifactId>flink-quickstart-java</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
should be unnecessary since flink-dist will provide it
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -92,6 +92,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
add comment who needs this (connector-files again?)
##########
File path: flink-connectors/flink-connector-elasticsearch7/pom.xml
##########
@@ -100,6 +100,13 @@ under the License.
<!-- Tests -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
add a comment that this is required by elasticsearch-base. (as is it
could probably be detected as unused)
##########
File path:
flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
##########
@@ -78,6 +78,12 @@ under the License.
</dependency>
-->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
This should be incorrect; as is it would be bundled in the user-jar.
This also shows the annoying side of this change. If a user wants to run
things in the IDE/tests they now have to add another dependency to their poms
(which they have no way of figuring out).
##########
File path: flink-formats/flink-json/pom.xml
##########
@@ -77,6 +77,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same as above
##########
File path: flink-formats/flink-csv/pom.xml
##########
@@ -76,6 +76,12 @@ under the License.
</dependency>
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same comment as for avro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
