rkhachatryan commented on pull request #18654: URL: https://github.com/apache/flink/pull/18654#issuecomment-1032378137
Thanks for the PR @masteryhx I have a couple of high-level remarks: - with materialization enabled (100ms interval), `ProcessingTimeWindowCheckpointingITCase#testSlidingProcessingTimeWindow` fails locally; could you please check this? - the change essentially replaces the use of `lastAppendedSequenceNumber` with `nextAppendedSequenceNumber` (and the former isn't use in production code anymore); so the latter should be covered by tests (e.g. `FsStateChangelogWriterSqnTest`) @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
