JingGe commented on a change in pull request #18666:
URL: https://github.com/apache/flink/pull/18666#discussion_r801961999
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -113,7 +113,8 @@ void testWriteOnBulkFlush() throws Exception {
writer.write(Tuple2.of(4, buildMessage(4)), null);
// Ignore flush on checkpoint
- writer.prepareCommit(false);
+ // TODO: clarify if it needs to be emulated with flush()
+ // writer.prepareCommit(false);
Review comment:
I think the flush() call is needed here, since the next line is to check
on purpose that Ids are not written when the flush has been triggered with a
false `flushOnCheckpoint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
