afedulov commented on a change in pull request #18666:
URL: https://github.com/apache/flink/pull/18666#discussion_r802745086
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriterITCase.java
##########
@@ -113,7 +113,8 @@ void testWriteOnBulkFlush() throws Exception {
writer.write(Tuple2.of(4, buildMessage(4)), null);
// Ignore flush on checkpoint
- writer.prepareCommit(false);
+ // TODO: clarify if it needs to be emulated with flush()
+ // writer.prepareCommit(false);
Review comment:
Oh yeah, that makes sense, I missed that bit (`flushOnCheckpoint =
false`). The existing test was not really checking the `flushOnCheckpoint` in
isolation, because the call was made with prepareCommit(**false**), i.e.
disabled by two variables at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
