CrynetLogistics commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803592814
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+ while (mailboxExecutor.tryYield()) {}
Review comment:
@dmvk Would you mind letting us know what technical issues you feel
there are here? I would be happy to address them and make fixes if necessary.
To answer your previous question, the semantic is don't buffer or write
anything if there are any failed requests waiting to be requeued or fatal
exceptions to fail the app with. If the user has super frequent checkpointing,
the async threads will be taking care of writing to the destination, and the
buffering will proceed as normal and not block here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
