dawidwys commented on a change in pull request #18702:
URL: https://github.com/apache/flink/pull/18702#discussion_r804434912



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -529,4 +625,43 @@ public void forceStop() {
             forcedStopFuture.complete(null);
         }
     }
+
+    /**
+     * TODO: this wrapper introduces a small performance regression when used. 
Maybe we can avoid

Review comment:
       An idea to drop the `WatermarkTrackingOutput` would be to make the 
`eventTimeLogic.createMainOutput` return e.g. `InternalReaderOutput` that would 
have the method `getLastWatermark`.
   
   I believe that's the approach Arvid took in his PoC.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to