slinkydeveloper opened a new pull request #18755:
URL: https://github.com/apache/flink/pull/18755


   This PR introduces a new API object called `TablePipeline` which 
encapsulates the description of an table pipeline, as a result of a compilation 
of an `INSERT INTO`. The implementation is simply a wrapper for 
`List<ModifyOperation>`. It also adds the method 
`StatementSet#add(TablePipeline)` to add a pipeline to a statement set.
   
   In order to improve the overall design quality of our APIs, in the first 
commit I introduced 3 interfaces splitting the capabilities of our API 
components:
   
   * `Compilable`: an object that can be compiled to a `CompiledPlan`
   * `Explainable`: an object that can be explained
   * `Executable`: an object that can be executed
   
   This brings overall consistency to our APIs and improves documentation. This 
change is a refactoring and doesn't bring any new feature, except the fluent 
`printExplain` method.
   
   The implementation of these capabilities is:
   
   |                 | `Compilable`       | `Executable`       | `Explainable`  
    |
   
|-----------------|--------------------|--------------------|--------------------|
   | `Table`         | FLINK-25843        | :heavy_check_mark: | 
:heavy_check_mark: |
   | `StatementSet`  | :heavy_check_mark: | :heavy_check_mark: | 
:heavy_check_mark: |
   | `CompiledPlan`  | Won't fix          | To be discussed?   | 
:heavy_check_mark: |
   | `TablePipeline` | :heavy_check_mark: | :heavy_check_mark: | 
:heavy_check_mark: |
   
   ## Verifying this change
   
   Added a test to verify a table pipeline can be compiled to a plan. The rest 
of the changes is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes
     - If yes, how is the feature documented? JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to