dmvk commented on a change in pull request #18761:
URL: https://github.com/apache/flink/pull/18761#discussion_r805959938
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraph.java
##########
@@ -205,6 +218,14 @@ AssignmentResult tryToAssignSlots(
* @return the main thread executor
*/
ComponentMainThreadExecutor getMainThreadExecutor();
+
+ /**
+ * Get a {@link State} the {@link AdaptiveScheduler} is currently in.
This is primarily
+ * intended for callbacks that need to outlive a state transition.
+ *
+ * @return The current state of the {@link AdaptiveScheduler}.
+ */
+ State getEffectiveState();
Review comment:
I did that in the first iteration, but it seemed confusing that you
actually have both `handleGlobalFailure` and `context.handleGlobalFailure`
methods available in the class and it's not clear what the difference is. This
felt bit more explicit for the reader.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
