zentol commented on a change in pull request #18761:
URL: https://github.com/apache/flink/pull/18761#discussion_r805968987
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/CreatingExecutionGraphTest.java
##########
@@ -135,10 +139,16 @@ public void
testNotPossibleSlotAssignmentTransitionsToWaitingForResources() thro
public void testSuccessfulSlotAssignmentTransitionsToExecuting() throws
Exception {
try (MockCreatingExecutionGraphContext context = new
MockCreatingExecutionGraphContext()) {
final
CompletableFuture<CreatingExecutionGraph.ExecutionGraphWithVertexParallelism>
- executionGraphWithvertexParallelismFuture = new
CompletableFuture<>();
- final CreatingExecutionGraph creatingExecutionGraph =
- new CreatingExecutionGraph(
- context,
executionGraphWithvertexParallelismFuture, log);
+ executionGraphWithVertexParallelismFuture = new
CompletableFuture<>();
+ final AtomicReference<Consumer<Throwable>> errorHandlerRef = new
AtomicReference<>();
+ new CreatingExecutionGraph(context,
executionGraphWithVertexParallelismFuture, log) {
+ @Override
+ OperatorCoordinatorHandler createOperatorCoordinatorHandler(
Review comment:
I'd rather add a OperatorCoordinatorHandler factory argument to the
CreatingExecutionGraph than resorting to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
