Aitozi opened a new pull request #18762: URL: https://github.com/apache/flink/pull/18762
## What is the purpose of the change This pull request is meant to improve the implementation of `Fabric8FlinkKubeClient#getRestEndpoint`. It's mainly done threes things - Refactor the FlinkKubeClient interface `getService` and `updateServiceTargetPort` to deal with service name directly which will eliminate the unnecessary enum of `KubernetesService.ServiceType`. - Port `Fabric8FlinkKubeClient#getRestEndpoint` method to the specific service type subclass - Remove the implicit behavior to use the Service externalIP as the address of the Endpoint which is the purpose of [FLINK-17232](https://issues.apache.org/jira/browse/FLINK-17232). I think it can be safely removed as i comments in the jira. Please correct me if I'm wrong. Or If I need to create a separate pull request for that issue, please let me know. ## Verifying this change This change is already covered by existing tests `Fabric8FlinkKubeClientTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes) - The S3 file system connector: (no) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
