Aitozi commented on pull request #18762: URL: https://github.com/apache/flink/pull/18762#issuecomment-1039242793
The code in `LoadBalancerService` and `NodePortService` is a bit duplicated, It's comes from the default fallback logic of the `LoadBalancer` service . I think it can be improved by remove the default fallback as describe in [link](https://github.com/apache/flink/pull/11715#discussion_r409302511) and [FLINK-17231](https://issues.apache.org/jira/browse/FLINK-17231). So in this PR, I keep the duplicated code. Please help to take a review when you are free @wangyang0918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
