CrynetLogistics commented on a change in pull request #18733:
URL: https://github.com/apache/flink/pull/18733#discussion_r806683366
##########
File path:
flink-connectors/flink-connector-aws-base/src/main/java/org/apache/flink/connector/aws/util/AWSGeneralUtil.java
##########
@@ -273,7 +274,15 @@ public static SdkAsyncHttpClient createAsyncHttpClient(
public static SdkAsyncHttpClient createAsyncHttpClient(
final AttributeMap config, final NettyNioAsyncHttpClient.Builder
httpClientBuilder) {
+ return createAsyncHttpClient(config, httpClientBuilder,
SdkEventLoopGroup.builder());
Review comment:
Right, I see. I elected to use the default as that's what the legacy
`flink-connector-kinesis` (based on KPL) was using. Your thoughts,
@dannycranmer ?
##########
File path:
flink-connectors/flink-connector-aws-kinesis-firehose/src/test/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkITCase.java
##########
@@ -130,7 +128,7 @@ public void test() throws Exception {
List<S3Object> objects =
listBucketObjects(
- createS3Client(mockFirehoseContainer.getEndpoint(),
httpClient),
+ s3AsyncClient,
Review comment:
(and this of course)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
