godfreyhe commented on a change in pull request #18363:
URL: https://github.com/apache/flink/pull/18363#discussion_r807484350
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/parse/CalciteParser.java
##########
@@ -47,12 +49,36 @@ public CalciteParser(SqlParser.Config config) {
* @param sql a sql string to parse
* @return a parsed sql node
* @throws SqlParserException if an exception is thrown when parsing the
statement
+ * @throws SqlParserEOFException if the statement is incomplete
*/
- public SqlNode parse(String sql) {
+ public SqlNode parse(String sql) throws SqlParserException {
Review comment:
need not declare the runtime exception
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/Parser.java
##########
@@ -44,9 +45,9 @@
*
* @param statement the SQL statement to evaluate
* @return parsed queries as trees of relational {@link Operation}s
- * @throws org.apache.flink.table.api.SqlParserException when failed to
parse the statement
+ * @throws SqlParserException when failed to parse the statement
*/
- List<Operation> parse(String statement);
+ List<Operation> parse(String statement) throws SqlParserException;
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
